Conversation
Trott
left a comment
There was a problem hiding this comment.
Rubber-stamp LGTM assuming this was done with the tools/update-eslint.sh script.
It was. It's a nice script. |
The process for maintaining ESLint is documented in the form of the |
Yep, just a few sentences should be okay, not looking for an essay or anything :) |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/11214/ @maclover7 I'll submit a follow up PR. |
|
@maclover7 @cjihrig I think in the case of dependencies in tools, we should probably just document the updating process together because those are relatively no-fuss and don't need that many words to explain. (don't need to document them all at once tho, just suggesting we name it as something like EDIT: although there are also gyp and icu which are a bit more compliated...but I still kinda want to see the guides in one place. |
PR-URL: nodejs#16738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
PR-URL: nodejs#16738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
|
This should be included in a larger backport of eslint to v6.x |
PR-URL: #16738 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Mostly wanted to try updating eslint because I haven't done it before.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools